Check my asm please

Hello everyone,

I have taken my knowlage from everyone here and from what I have learn hands on from helping on projects which I enjoyed helping with, and I have my first asm I hope. The reason I say I hope is due to the fact I could of made a mistake and not know it, it could be poor. So before I try to make a patch out of it could I ask all of you to if you have free time to look threw and let me know what mistakes I had made so I could go back and fix it. I am just asking for feed back on this before I try it. The game is pinball dreams, I worked on it inbetween on my free time, so if its really bad I understand.Thank you very much for takeing the time to look at it and thank you for any comments made.

Code:

lorom

org $808C31
JSL msuTrack

org $80B213
JSL pauseStart
NOP
NOP
NOP

org $80B17E
JSL pauseEnd
NOP
NOP

org $809D8D
JSL playSignal
NOP

org $80B1CF
msuTrack:
PHA
PHP
SEP #$20
lda $2002
CMP #$53
BEQ $07
PLP
PLA
AND #$00FF
ASL A
RTL
PLP
PLA
PHA
TXA
PHP
SEP #$20
JSL msuRoutine
PLP
PLA
AND #$00FF
ASL A
RTL

msuRoutine:
STZ $2006
STA $2004
STA $7FE000
STZ $2005
loop:
bit $2000
BVS loop
LDA #$02
STA $7e0018
RTL

playSignal:
sta $04
sta $2140
lda $2002
CMP #$53
BEQ $01
RTL
LDA #$03
STA $2007
LDA #$ff
STA $2006
RTL

pauseStart:
PHA
PHP
SEP #$20
lda $2002
CMP #$53
BNE resumeStart
LDA #$0B  
STZ $2006
STA $2004
STZ $2005
loop1:
bit $2000
BVS loop1
LDA #$03
STA $2007
LDA #$ff
STA $2006
LDA #$02
STA $7e0018
resumeStart:
PLP
PLA
LDA #$000B
JSL $809D8D
RTL

pauseEnd:
PHA
PHP
SEP #$20
lda $2002
CMP #$53
BNE resumeEnd
LDA $809D8dD  
STZ $2006
STA $2004
STZ $2005
loop2:
bit $2000
BVS loop2
LDA #$03
STA $2007
LDA #$ff
STA $2006
LDA #$02
STA $80B1CF
resumeEnd:
PLP
PLA
LDA $02
JSL $809D8D
RTL

BNE resumeEnd
LDA $809D8dD  
Does not compile (D) at the end here.

I must have the wrong rom (tested US and Europe rom) - I didn't get the breakpoints you used. Checking the code it doesn't match as well (e.g., I could not find LDA $04 - Sta $2140 anywhere in the native code (a9 04 8d 04 20) neither LDA #$02 - STA $7e0018 (a9 04 8f 18 00 7f)

Unfortunately, I can't be of much help, I enjoy my retirement... much luck in any case

Conn wrote:BNE resumeEnd
LDA $809D8dD  
Does not compile (D) at the end here.

I must have the wrong rom (tested US and Europe rom) - I didn't get the breakpoints you used. Checking the code it doesn't match as well (e.g., I could not find LDA $04 - Sta $2140 anywhere in the native code (a9 04 8d 04 20) neither LDA #$02 - STA $7e0018 (a9 04 8f 18 00 7f)

Unfortunately, I can't be of much help, I enjoy my retirement... much luck in any case

Thank you any ways conn . I had used the usa one and I was useing cheats. Any who, back to the drawing board