I found a bug, but I need to find another location with this particular situation to confirm.  If there is a pot covering a floor switch that reveals a treasure chest (plays the "ding" sfx instead of "crunch"), if you run into the pot with the pegasus boots, it will trigger the switch, but the sprite isn't updated, so it looks like the pot is still there, but you can't pick it up and you can walk on it.  The one I had this happen on was in the basement of the Dark Palace.  Due to the hitbox of the floor switch, you may have to run downwards from above to trigger this, but like I said, I need to find another switch like this to test further.

I tried on this location:


(eastern palace, need to cheat for boots 7ef379-ff - code enables run, boots won't show up in menu but it's enough to test).

You are right, strangely it only happens when running from above into it. Will check

Edit: It doesn't appear always. It seems like you are too fast so that the tile replacement isn't executed, and won't happen anymore after you hit the Switch. This could get much complicated to fix (and is Little bug most People won't run into). I'll see whether I can do anything about.

ok, I figured that the pot destroy is dependant on your x-coordinate. I also noticed when placing you always 2 Pixels to the left, the pot will be smashed and stays it.

Carefully! check this hack
http://bszelda.zeldalegends.net/stuff/Con/l2pot_v2.ips

I will not guarantee anything, neither I can exclude side effects.

Can you describe what this fix does so I have a better idea what to pay attention for?

well, it should fix the pot being (not) destroyed... it doesn't work?

What it does: when running from up->down it seems that the pot destroy only works when Standing correct on the x-axis. I did some testings and noticed that, when placing Link 2 Pixels further left, the pot gets always destroyed.

So I made first a check whether you're running, then if you're running down. If you then hit a pot, move Link 2 Pixels left.

I haven't gotten a chance to check it yet. Just, knowing that there are only a few places with switches like this, I was curious to know how you'd fixed the issue, so I knew what to try out. Knowing what's supposed to happen helps determine what edge cases to test for.

mh, take the v3 for testing, made another security check (check whether it is really a pot):
http://bszelda.zeldalegends.net/stuff/Con/l2pot_v3.ips

Looks good.  Found another switch in the Ice Palace that I was able to trigger the original issue and compare it to the v3 fix, and v3 works perfectly.  You mentioned the possibility of side effects, so I'll be on the lookout for those (proving the absence of something is far more difficult than proving the existence of something )

Nice to hear. I updated the zip Archive, so if you redownload the
Ips Patch: http://bszelda.zeldalegends.net/stuff/Con/pott_l2sword.zip
you find the updated file.
So anybody please reapply (also PU), but this fix is also very Little.

I was wrong, $20 is the y-coordinate not x, as I thought previously.
I made three checks to provide Minimum of possible bug side-effects:
- check if you are running against a pot (e.g. hammer jambs also Trigger the execute code)
- check if you are running with boots
- check if your direction is up-> down

If all this is true, move Link 2 Pixels upward - then the pot stays smashed. So the only place where bugs can occur with this new code is when running from up->down smashing pots, through the movement of Link's sprite. The running is so fast and the movement is only 2 Pixels that this is not recognizeable.

Edit:
mmh, I corrected my code to v4 (redownload the zip from the original Archive in the main post). The reason is that the y coordinate is a 2 Byte (word) read and I substract 02.
One Byte read:
Eg. $20: 08 05 - 00 02 = 08 03 (correct). But if you come below the first Byte,
eg. $20: 08 01 - 00 02 = 08 FF - this would store you 5-10 cm below your current Location. This Happening would be rare but possible (Chance 128:1).
Therefore I made a 2 Byte substract in Version 4 so that now it will be
$20: 08 01 - 00 02 = 07 FF (which then is correct)

Anyhow, could you send it by email to me and add the lvl 1 baseball bat also so that it makes more sense?

I wouldnt mind destroying them with fists also!! So yeah please enable lvl 0 aswell.

I sent you the patch, and merged all latest bug-fixes
- pegasus run fix on staircases
- grab-item fix to not take harm from e.g. bubble
- pot destroy fix when running up->down

I was also able to make pots destroy with L1 sword, L0 (fist) isn't possible since the routine isn't executed without sword

For anybody else who likes to tinker this:
L1-L4 sword, just make
07/7b92: D0 -> 80

L2-L4 sword: default

L3-L4 sword make
07/7b90: 01 00 d0 -> 03 00 b0

L4 Sword only
07/7b90: 01 00 d0 -> 04 00 F0

Alright thanks!

I haven't applied the sword grabbing patch yet so is it okay if I just apply the fix?

Yes, it will also enable it (even when not having pre-applied it)

Alright thanks!

Don't Forget to send me a fresh Version... if my Version is too old I can accidently overwrite code.

Here's an idea for another improvement on this.  In the GBA version, you can also break pots with the bow and arrow, and the silver arrows actually continue through a pot, hitting whatever is behind it, so you can break a whole row of pots with a single shot.  Any chance you might be interested in adding that here?

No I am not
This is quite difficult and no "real benefit" out of it. Furthermore, bugs from all previous patches were really eating me (remember the 2 weeks msu? I had the same shit with the feather and other patches), so I'm not really interested in developing new things right now - then there's upcoming stuff to do with PU (Special msu adjustements) and bszelda1 (spc&msu).

That's totally fine, I just thought I'd bring it up.  There's actually a handful of item hit adjustments like that in the GBA version, like the fire rod burning bushes, or the L2 boomerang cutting grass and bushes, but if those don't interest you, I understand.  They also have the lantern doing damage like you do, but I intentionally left that one out of DX because it would allow sequence breaking by beating the Ice Palace without having the fire rod... although, on second thought I may go ahead and add it in for just that reason.  You can already do a fair bit of sequence breaking, might be fun to add that option.

you see, I'd only add new Features when having a benefit. Cutting grass with a boomerang has None. Smashing pots through arrows would have one if you e.g. can add a Crystal Switch behind and a gap between you and this. But this also can be activated by cane somaria. All in all those patches would attract bugs like a rotten corpse and I avoid Walking down that road as best as I can

I think your dx hack is perfect as it is. You'd Need to apply the complete items hack which will overwrite your msu hack to have the super lantern; furthermore you Need to store a second lamp somewhere to upgrade it, and remove the 5 rupees alternative lantern chests on the way to Zelda. Best is you leave your Version as it is and make a complete new hack with custom dungeons if you use my hacks.

I didn't realize your super lantern was an upgrade, so yeah, I won't be adding that.

Would you please restore the "item dash" glitch, from the Japanese version 1.0 copy of the game, into the all-in hack. It works by pressing the "Y" button, at the same time as holding the "A" button, which replaces the sword with whatever item you were using. I would like to have a patch made to re-implement the glitch.
Thank you for helping.

Last edited by stgiga on Sun 1 Feb 2015 - 15:03; edited 1 time in total (Reason for editing : I am revising what I said.)

I tried, you see Y-pressed is stored to $F4. The read is disabled if a value is written to $5d (#$11 for dash). If I'd disable this this affects the whole Rom as the hookshot also writes to $5d (#$13) to not use other items while the Routine is executed..

This will render the complete Rom unplayable so I have to decline "this request".

Ok.

I've noticed there's some weirdness with the hitbox of this patch.  It doesn't seem to quite line up with the sword hitbox on the L2+ swords.  Specifically, at the extreme range of the hitbox sword, you can hit the pot without it breaking.  I originally thought that maybe it was still using the original hammer hitbox, but I tested that and that doesn't seem to be the case either (see the second pot in the video).  So the pot breaking hitbox has a longer range than the hammer, but a shorter range than the sword.  It's not a huge issue, but I do quite often find myself thinking "I'm sure I hit that, why didn't it break?"