Nice you too have a great day!

Your welcome and thank you :-D

I noticed another problem:

Track 65 = SMB3 end theme.
Track 97 = SMB3 normal level (ex: world 1.2, 1.3 etc).

But in these two places only play the song that is in position 97, the track 65 is completely ignored, please check this out, OK?

(Note: In some packs the tracks 65 and 97 are reversed, then I will check everything and report here which ones are wrong, thanks.)

Last edited by darthvaderx on Fri 15 Feb 2019 - 18:11; edited 1 time in total

If you check page 3 of this thread jud6ment reported such problems exactly with these themes, and I actually fixed that. I might have fixed it with a wrong ram. Are you sure you have the latest.patch version, v5?
If yes, please provide a bsnes savestate right before you enter a level where the wrong theme is played.

Oh and it is possible that it is a problem with the packs. Please check if it occurs in jud6ment pack, here all themes should be correct. If it is a pcm set problem that occurs in some packs only (reversed) I at least know it is not a problem with the new code.

Yes, I'm using v5, does it serve a Snes9x savestate? (I do not like Bsnes.)

https://www.dropbox.com/s/b4hzsm6ns4b2k22/sma_msu1.000?dl=0

And I checked here and all the packs are normal, I'm sorry.

Ok, I can't load your savestate, there are couple of snes9x versions out there, with each savestate different and incompatible. So I hacked blindly without testing:

Download v6 (16-Feb-2019) chime ending fix, 2nd:
http://bszelda.zeldalegends.net/stuff/Con/sma_msu1_patch.zip


What I did... in the last version I used ram $7ffb00 to determine whether you are in world 8, so the chime shall play. Now I looked into smw central ram map and it says:

$7FFB00 1 byte World World number loaded from save file. Used in order to load the correct world number after the title screen.

So apparently this differentiation works only when going into world 8 via save from menu.

So now I did the following. Theme #$0e (respectively $6e = pcm-110 is unique to bowser dying. When this theme is played I set a flag, so that the next time, when track-97 is about to play, it shall play -65

Please test, as said I could not verify it working. If it does not I'd need to invest the time and play to Bowser myself I guess.
Important is, when you test is that your savestate is before you defeat bowser, theme 110 (bowser dies) needs to be played in order to set the new flag

Snes9x 1.58 x64, the same problem remains.

Here is my before-Bowser savestate:

https://www.dropbox.com/s/nkabgvohjiy1k1v/sma_msu1.000?dl=0

The noise of the falling Bowser works perfectly.

mmh, it works perfectly for me:

1fee53 cmp #$6e               A:036e
1fee55 bne $ee5e     [1fee5e] A:036e
1fee57 lda #$01               A:036e X:0002
1fee59 sta $16a6     [0016a6] A:0301

What you see here: I make a check whether it is $6e, bowser dying. and set a flag to 16a6

Then when you meet the princess:

1fee5e cmp #$61               A:2161
1fee60 bne $ee72     [1fee72] A:2161
1fee62 lda $16a6     [0016a6] A:2161
1fee65 cmp #$01               A:2101
1fee67 beq $ee6d     [1fee6d] A:2101
1fee6d lda #$41               A:2101
1fee6f stz $16a6     [0016a6] A:2141

What happens here is, that when the flag is set, and about to play $61, it will play $41. I checked bsnes, here it works Will try to get your savestate working.

Edit:
Testing with your savestate, it works as well.
Check whether you patched correctly and loaded the new version. If this won't work... well then we'd need an independent third person to check

Unfortunately it continues with the same problem, I will use another emulator to test but then I will have to play it all again.

There's also the possibility that you need to clear the browser history. It happened to me sometimes, that firefox uses an old patch file since I downloaded it a short while ago if the link remains the same (and doesn't download the new file).

Please check that the date of the ips is 16th february 19 and the ips size is 957 bytes

Oppss, ips date (inside zip) : 21th december 18 and 941 bytes. (Downloaded now from link).

EDIT: I downloaded it through another browser now and this time it gave the correct date, I'll test immediately.

Finally, IT WORKS PERFECTLY !!! Again thank you very much for all your work.
But I'm curious about this bug on the Firefox, this should not happen, I'm thinking here now in the several times that I downloaded a patch thinking that it was updated but that it was actually the old one, I should check everything.
Finally as thanks I will post something very interesting in Secret of Mana topic, bye

It is out of my experience. Firefox has a download history and if the link url does not change it uses the file from the history. Only thing you can do is clear chronicles to be sure to get the latest file.

Ah well. I'm happy it is resolved together with the bug ...and looking forward to your news on som.

PCM set by Kurrono v3

sma_msu1-101.pcm does not sound like Bowser Fight Theme in Super Mario Bros 3. It sound like Pick a Box Theme. This file needs to be fix.

ABOhiccups wrote:PCM set by Kurrono v3

sma_msu1-101.pcm does not sound like Bowser Fight Theme in Super Mario Bros 3. It sound like Pick a Box Theme. This file needs to be fix.

@ABOhiccups Notified Kurrono about the reported issue. Will have to wait for his response.

For me here it works perfectly, it was just after several corrections until reaching the V6 patch that the Bowser Fight Theme plays correctly. I will download the set again and do a new test.

The issue is Kurrono set, track 101 is the pick up here. This theme needs to be replaced with the correct one.

Luckily it isn't the patch

@darthvader can you check all themes of K's set whether he mixed up more? So that he won't need to replace piecewise... is the pick up correct (I do not know its number?

Yes, it seems like the problem is really with Kurrono's own set, I didn't have this problem because I set up my own track selection and pcm 101 is really from battle, then I will test the other sets to see if there is the same error .

NES OST set by Relikk have the same problem, Enmet's and JUD6MENT's are normal.

Thanks, Kurrono informed me that Pev will (hopefully) update the set soon.
I also hope Relikk will read this and updates his set as well.

Since there was no track map and that there is 100+ tracks, I had to resort to copying and relying on the track numbers in someone elses set.

I'll take a look soon.

@Kurrono Uh, I thought you were fixing your set? Let me know if you are having issues accessing the host site. It would be easier to do it from your end.

@Kurrono Never mind, I had some free time to fix your track 101 problem. I went ahead and put the fixed set on the host server (on your end).

@Conn Please update your master list due to the link change. Thanks

It does play Bowser Battle Theme. But it plays Underground Theme from Super Mario Bros 1 & Lost Levels after that during Bowser Battle.